fix: auto-recall passes embeddings model to backend (0.7.2)#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug report validated and fixed. Auto-recall (UserPromptSubmit hook) called
ollama.embed(query, None)atrecall.rs:157, which Ollama tolerates (falls back to its own configured model) but Azure rejects withDeploymentNotFound. Result: silently dark semantic recall on Azure-routed embeddings.Fix
embedding_model: Option<String>field +with_embedding_model(...)builder onRecallEngine.embed()fromtry_semantic.clx-hookfromconfig.capability_route(Capability::Embeddings).model;clx-mcpfrom its existingembed_modelfield.Tests
embedding_model_builder_persists_value— locks the contract.embedding_model_default_is_none_for_back_compat— Ollama callers without explicit model still work.Live-verified
UserPromptSubmitwith full-Azure config;grep 'Recall semantic embedding failed' ~/.clx/logs/clx.logreturns nothing after the fix.Affects
Anyone routing
llm.embeddingsto Azure (or any future backend without a baked-in default model). Hybrid configs (Ollama embeddings) are unaffected — that's why nobody noticed in 0.7.0.