Skip to content

fix: auto-recall passes embeddings model to backend (0.7.2)#23

Merged
blackaxgit merged 3 commits into
mainfrom
fix/auto-recall-azure-embed-model
May 2, 2026
Merged

fix: auto-recall passes embeddings model to backend (0.7.2)#23
blackaxgit merged 3 commits into
mainfrom
fix/auto-recall-azure-embed-model

Conversation

@blackaxgit
Copy link
Copy Markdown
Owner

Bug report validated and fixed. Auto-recall (UserPromptSubmit hook) called ollama.embed(query, None) at recall.rs:157, which Ollama tolerates (falls back to its own configured model) but Azure rejects with DeploymentNotFound. Result: silently dark semantic recall on Azure-routed embeddings.

Fix

  • Add embedding_model: Option<String> field + with_embedding_model(...) builder on RecallEngine.
  • Forward it to embed() from try_semantic.
  • Both production callers pass it: clx-hook from config.capability_route(Capability::Embeddings).model; clx-mcp from its existing embed_model field.

Tests

  • embedding_model_builder_persists_value — locks the contract.
  • embedding_model_default_is_none_for_back_compat — Ollama callers without explicit model still work.

Live-verified

  • Triggered UserPromptSubmit with full-Azure config; grep 'Recall semantic embedding failed' ~/.clx/logs/clx.log returns nothing after the fix.

Affects

Anyone routing llm.embeddings to Azure (or any future backend without a baked-in default model). Hybrid configs (Ollama embeddings) are unaffected — that's why nobody noticed in 0.7.0.

@blackaxgit blackaxgit merged commit 0591e7e into main May 2, 2026
7 checks passed
@blackaxgit blackaxgit deleted the fix/auto-recall-azure-embed-model branch May 2, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant