Add AI assistant skill installation#17
Conversation
|
A few directional points before this lands: 1. Rename 2. Drop the dedicated CLI skill; make the canonical install be the hub skill from 3. Reuse the existing Net effect if all three land: |
|
Thanks for the thoughtful review — I agree with point 2 that the dedicated CLI skill risks becoming duplicate-maintenance if it remains a hand-curated help dump. One bit of context: this CLI skill was already present before this PR as the hidden Given your point, should we remove the dedicated CLI skill entirely instead of preserving/moving the existing behavior? |
|
One more thing to consider @lukaskroepfl: I will however revert to the previous behaviour to focus on the core scope of the pr. |
|
Update pushed with the follow-up simplifications:
Verification run locally:
|
lukaskroepfl
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround — sorry, I missed your two earlier comments before posting my last follow-up (since deleted). The new shape is exactly the direction I was hoping for:
bitmovin skills add/list/removeas thin wrappers aroundnpx [email protected]✓tardep and the archive/extract/install pipeline gone ✓bitmovin initremoved ✓- Scope tightened by dropping
find✓ - Keeping the hidden
bitmovin skillin pre-PR form ✓ — fair scope call; the "skill as discoverability/decision-guidance vs duplicate help" debate is its own conversation and doesn't need to block this.
A couple of small things worth a glance, none blocking:
npx.tspins[email protected]— good for predictability; just worth noting we'll need to bump it deliberately, won't pick up patches automatically.buildSkillsAddArgsuses--global --copy --yes; the--yesshows up twice in the final argv (once fornpx, once forskills). Not a bug, just slightly noisy — fine to leave.- The
refflag ishidden: trueonadd/listbut documented in--helpdescription as "Git ref to read skills from"; consistent across both, good.
LGTM.
Summary
bitmovin initand legacybitmovin skilloutputbitmovin skills list/find/add/removefor remote Bitmovin skillsbitmovin/skillsGitHub archive viaskills/*/SKILL.mdVerification
npm run buildnpm testnpm run lintbitmovin skill,bitmovin init,skills list,skills find, andskills add --dry-run