guard against small inputs in nCountRnaStratification - #312
Conversation
|
Regarding the test failures, the Seurat one is easy to fix by sanitizing the gene lists to ensure they're within the Seurat object. The omnipathR one is more in their wheelhouse. I am pretty sure it starts here upon decoupler failing to hit the omnipath API via I tested to see if we were just hitting a timeout, so I bumped I think the problem with pulling the live omnipathR table is actually inside of omnipathR's taxonomy db, since they seem to store missing values as traceback here: |
|
@GWMcElfresh : thanks for following up. if your last change fixes the seurat-related issue, then let's merge this. deCoupler/OmnipathR is a discrete failure that will only hit that package. I am wondering if we should transition from R to python for that, since their python package seems to have more active development. |
Hi @bbimber,
Small check here to ensure the input scRNASeq dataset, before pseudobulking, can be assessed for nCountRNAStratification.
I'm pretty sure these prime-seq errors are just the typical on-the-fly type conversions based on the object's dimensions that R does all the time.
The assumption baked in here is that if we can't assess clustering, we'll just assume it's 'normalRNACounts' - since by definition the input is probably small. We'll typically filter those datasets based on cell counts prior to modeling, so not a huge deal in my opinion.
Let me know if you'd like anything else here!
GW