Make Prior.__repr__ round-trippable for numpy scalar parameters#1108
Open
lorenzopompili00 wants to merge 1 commit into
Open
Make Prior.__repr__ round-trippable for numpy scalar parameters#1108lorenzopompili00 wants to merge 1 commit into
lorenzopompili00 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restores Prior.__repr__ round-trippability when prior parameters are NumPy scalar types (notably under NumPy >= 2.0 where scalar repr() includes an np. prefix), preventing PriorDict parsing from mistakenly attempting import_module("np").
Changes:
- Convert NumPy scalar values (
np.generic) to native Python scalars via.item()when buildingPrior.__repr__. - Add a regression test ensuring
repr()output forUniformwith NumPy scalar bounds contains nonp.and can be parsed back viaPriorDict.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bilby/core/prior/base.py |
Ensures Prior.__repr__ emits native Python scalar literals for NumPy scalar parameters to keep from_repr / _parse_argument_string round-trippable. |
test/core/prior/base_test.py |
Adds coverage to prevent regressions in repr() round-tripping for priors constructed with NumPy scalar parameters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With numpy 2.0+,
repr()of numpy scalars carry annp.prefix (e.g.repr(np.float64(0.0))is"np.float64(0.0)"). This goes intoPrior.__repr__, and bilby's parserPrior._parse_argument_stringthen fails to re-parse it: it treatsnpas a module and callsimport_module("np")which fails.Can be reproduced by running
This fixes it by converting numpy scalars to native Python types in
Prior.__repr__