FEAT: add precessing spin transformation#1104
Open
ColmTalbot wants to merge 1 commit into
Open
Conversation
GregoryAshton
left a comment
GregoryAshton
left a comment
Collaborator
There was a problem hiding this comment.
Broadly looks good to me - albeit the checks are failing
| return theta, phi | ||
|
|
||
|
|
||
| def transform_precessing_spins( |
Collaborator
There was a problem hiding this comment.
This is overwriting an existing function with a properly vectorised version if I have understood correctly. Typically, I'd think it would be better to use a new name. However, I can see there are tests to ensure the two agree.. so I'm inclined to say this seems like a good idea.
| - spin_2x, spin_2y, spin_2z: Components of spin 2 | ||
| """ | ||
|
|
||
| xp = array_module(theta_jn) |
Collaborator
There was a problem hiding this comment.
Does array_module here just take theta_jn to figure out the array type?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement for #1044 that includes the backend changes rather than attempting to rebase.