Skip to content

Add favicon#14

Open
gchahal1982 wants to merge 1 commit into
bigearth:masterfrom
gchahal1982:verity/github-github-com-bigearth-bitblog-issues-1
Open

Add favicon#14
gchahal1982 wants to merge 1 commit into
bigearth:masterfrom
gchahal1982:verity/github-github-com-bigearth-bitblog-issues-1

Conversation

@gchahal1982
Copy link
Copy Markdown

Summary

Narrow patch plan for Add favicon

Linked Issue

#1

Verification

$ python3 -c from pathlib import Path; import sys; missing=[p for p in sys.argv[1:] if not Path(p).exists()]; print('checked files: '+', '.join(sys.argv[1:])); raise SystemExit(1 if missing else 0) _layouts/default.html assets/favicon.svg
exit=0
checked files: _layouts/default.html, assets/favicon.svg

$ python3 -c from pathlib import Path; import re, sys; text='\n'.join(Path(p).read_text(encoding='utf-8', errors='ignore') for p in sys.argv[1:] if Path(p).suffix.lower() in {'.html','.ecr','.erb','.liquid','.astro','.md','.mdx'}); has_icon=bool(re.search(r'rel=["'][^"\']*(icon|apple-touch-icon)', text, re.I)); has_asset=any(Path(p).suffix.lower() in {'.ico','.png','.svg','.webmanifest'} for p in sys.argv[1:]); print('static link check: icon_link=%s asset=%s' % (has_icon, has_asset)); raise SystemExit(0 if (has_icon or not has_asset) else 1) _layouts/default.html assets/favicon.svg
exit=0
static link check: icon_link=True asset=True

Proof Artifact

Evidence lane: code_patch
Patch commit: bb489d1 (signed)

@gchahal1982
Copy link
Copy Markdown
Author

Hi, just checking in on this PR. Is there anything you'd like changed before review? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant