Add favicon#14
Open
gchahal1982 wants to merge 1 commit into
Open
Conversation
Author
|
Hi, just checking in on this PR. Is there anything you'd like changed before review? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Narrow patch plan for Add favicon
Linked Issue
#1
Verification
$ python3 -c from pathlib import Path; import sys; missing=[p for p in sys.argv[1:] if not Path(p).exists()]; print('checked files: '+', '.join(sys.argv[1:])); raise SystemExit(1 if missing else 0) _layouts/default.html assets/favicon.svg
exit=0
checked files: _layouts/default.html, assets/favicon.svg
$ python3 -c from pathlib import Path; import re, sys; text='\n'.join(Path(p).read_text(encoding='utf-8', errors='ignore') for p in sys.argv[1:] if Path(p).suffix.lower() in {'.html','.ecr','.erb','.liquid','.astro','.md','.mdx'}); has_icon=bool(re.search(r'rel=["'][^"\']*(icon|apple-touch-icon)', text, re.I)); has_asset=any(Path(p).suffix.lower() in {'.ico','.png','.svg','.webmanifest'} for p in sys.argv[1:]); print('static link check: icon_link=%s asset=%s' % (has_icon, has_asset)); raise SystemExit(0 if (has_icon or not has_asset) else 1) _layouts/default.html assets/favicon.svg
exit=0
static link check: icon_link=True asset=True
Proof Artifact
Evidence lane: code_patch
Patch commit: bb489d1 (signed)