Skip to content

Jlm#80

Merged
beykyle merged 11 commits into
mainfrom
jlm
May 29, 2026
Merged

Jlm#80
beykyle merged 11 commits into
mainfrom
jlm

Conversation

@beykyle

@beykyle beykyle commented May 28, 2026

Copy link
Copy Markdown
Owner
  • Add LDA and ILDA folding capabilities
  • add JLM microscopic BHF nuclear matter self energy parameterization
  • add JLMB energy renormalization
  • add JLM and JLMB functions for computing finite nucleus self-energy given nuclear matter density
  • add nuclear matter density tables and parameterizations from TALYS
  • add extensize example demoing new capabilities

@beykyle

beykyle commented May 28, 2026

Copy link
Copy Markdown
Owner Author

@copilot Please review this pull request (You don't have to review the contents of @src/data/densities/, this is just data, just the source code, docs and example updates).

Copilot AI commented May 28, 2026

Copy link
Copy Markdown
Contributor

@copilot Please review this pull request (You don't have to review the contents of @src/data/densities/, this is just data, just the source code, docs and example updates).

Reviewed the PR changes (excluding src/data/densities/). I found one medium-severity issue:

  • src/jitr/folding/jlm.py (W0 around line 150, W1 around line 266): both use terms with 1 / (E - E_F) (or squared), so E == E_F can trigger divide-by-zero runtime warnings and unstable edge-case behavior near the Fermi surface. Suggest guarding with a small epsilon or safe np.where handling.

No other high-signal blockers stood out in the source/docs/examples changes.

@beykyle

beykyle commented May 28, 2026

Copy link
Copy Markdown
Owner Author

@copilot Please make a commit resolving the potential divide by 0 issue.

Copilot AI commented May 28, 2026

Copy link
Copy Markdown
Contributor

@copilot Please make a commit resolving the potential divide by 0 issue.

Implemented in commit 2f03210.

W0 and W1 now use epsilon-stabilized denominators around E == E_F to prevent divide-by-zero warnings while keeping behavior finite near the Fermi surface. I also added regression coverage in tests/test_jlm_optical.py for both exact and near-Fermi energies.

@beykyle

beykyle commented May 28, 2026

Copy link
Copy Markdown
Owner Author

TODO:

  • finish example_jlm.ipynb, including cross section calculation

@beykyle beykyle merged commit 14b85dd into main May 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants