fix(webstrap): stub Sparkle query params in web shell#53
Draft
zhuziqi97 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appUpdates.setSparkleQueryParams()implementation to the Linux Web Shell app-host RPC.Root cause
Upstream prod build
26.715.21425(build5488) calls:The Linux Web Shell exposed
appUpdates, but did not implementsetSparkleQueryParams. Optional chaining guarded onlyappUpdates, so themissing method caused:
Behavior
Linux Web Shell does not have a native Sparkle updater. The new method is
therefore an intentional no-op that preserves RPC compatibility without
changing update behavior.
Validation
node --test test/web-assets.test.mjs— 12 passednode --test test/*.test.mjs— 96 passed26.715.21425/ build5488smoke — all checks passedweb-browser-shellnpm testalso discovers ignored generated tests underdist/andstage/;those contain six pre-existing missing generated server-module failures. The
controlled repository test suite passes.