Skip to content

fix(webstrap): stub Sparkle query params in web shell#53

Draft
zhuziqi97 wants to merge 1 commit into
better-slop:mainfrom
zhuziqi97:codex/fix-web-shell-sparkle-query-params
Draft

fix(webstrap): stub Sparkle query params in web shell#53
zhuziqi97 wants to merge 1 commit into
better-slop:mainfrom
zhuziqi97:codex/fix-web-shell-sparkle-query-params

Conversation

@zhuziqi97

Copy link
Copy Markdown
Contributor

Summary

Root cause

Upstream prod build 26.715.21425 (build 5488) calls:

ki.appUpdates?.setSparkleQueryParams({ planType: o })

The Linux Web Shell exposed appUpdates, but did not implement
setSparkleQueryParams. Optional chaining guarded only appUpdates, so the
missing method caused:

TypeError: ki.appUpdates?.setSparkleQueryParams is not a function

Behavior

Linux Web Shell does not have a native Sparkle updater. The new method is
therefore an intentional no-op that preserves RPC compatibility without
changing update behavior.

Validation

  • node --test test/web-assets.test.mjs — 12 passed
  • node --test test/*.test.mjs — 96 passed
  • Cached prod build 26.715.21425 / build 5488 smoke — all checks passed
  • Full prod canary build — 11/11 checks passed, including web-browser-shell

npm test also discovers ignored generated tests under dist/ and stage/;
those contain six pre-existing missing generated server-module failures. The
controlled repository test suite passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream canary failed: prod web-browser-shell 26.715.21425

1 participant