Skip to content

fix notifications for sdk28 (also works for lower SDKs) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-edery wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix notifications for sdk28 (also works for lower SDKs) #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fadecandy-service/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ apply plugin: 'kotlin-android'
apply plugin: 'kotlin-android-extensions'

android {
compileSdkVersion 27
compileSdkVersion 28
buildToolsVersion "26.0.3"

lintOptions {
Expand All @@ -14,7 +14,7 @@ android {

defaultConfig {
minSdkVersion 16
targetSdkVersion 27
targetSdkVersion 28
versionCode 7
versionName "1.62"

Expand Down
2 changes: 1 addition & 1 deletion fadecandy-service/src/main/java/fr/bmartel/android/fadecandy/service/FadecandyService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ class FadecandyService : Service() {
return Service.START_NOT_STICKY
}
ServiceType.PERSISTENT_SERVICE -> {
startForeground(4242, NotificationHelper.createNotification(this, null, testIntent))
startForeground(1, NotificationHelper.createNotification(this, null, testIntent))
Log.v(TAG, "starting PERSISTENT_SERVICE...")
return Service.START_STICKY
}
Expand Down
28 changes: 27 additions & 1 deletion fadecandy-service/src/main/java/fr/bmartel/android/fadecandy/utils/NotificationHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,12 @@
package fr.bmartel.android.fadecandy.utils

import android.app.Notification
import android.app.NotificationChannel
import android.app.NotificationManager
import android.app.PendingIntent
import android.content.Context
import android.content.Intent
import android.os.Build
import android.support.v4.app.NotificationCompat

import fr.bmartel.android.fadecandy.R
Expand All @@ -43,6 +46,10 @@ import fr.bmartel.android.fadecandy.service.FadecandyService
*/
object NotificationHelper {

val CHANNEL_ID = "fadecandyServiceChannelID"
val CHANNEL_NAME = "fadecandyServiceChannel"
val CHANNEL_DESCRIPTION = "FadeCandy Service Channel"

/**
* Create the intent to be launched when user click on notification.
*
Expand All @@ -66,16 +73,19 @@ object NotificationHelper {
*/
fun createNotification(context: Context, content: String?, activityIntent: Intent): Notification {

createNotificationChannel(context)

val title = context.getString(R.string.app_name)
val pendingIntent = createLaunchIntent(context = context, activityIntent = activityIntent)

val builder = NotificationCompat.Builder(context)
val builder = NotificationCompat.Builder(context, CHANNEL_ID)
.setContentTitle(title)
.setSmallIcon(R.mipmap.ic_launcher)
.setContentText(content)
.setContentIntent(pendingIntent)
.setPriority(NotificationCompat.PRIORITY_HIGH)
.setOngoing(true)
.setChannelId(CHANNEL_ID)

val yesReceive = Intent()
yesReceive.action = FadecandyService.ACTION_EXIT
Expand All @@ -84,4 +94,20 @@ object NotificationHelper {

return builder.build()
}

private fun createNotificationChannel(context: Context) {
// Create the NotificationChannel, but only on API 26+ because
// the NotificationChannel class is new and not in the support library
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O)
return

val notificationManager = context.getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager?
if (notificationManager!!.getNotificationChannel(CHANNEL_ID) != null)
return

val channel = NotificationChannel(CHANNEL_ID, CHANNEL_NAME, NotificationManager.IMPORTANCE_DEFAULT)
channel.description = CHANNEL_DESCRIPTION
notificationManager.createNotificationChannel(channel) // Register the channel with the system; you can't change the importance or other notification behaviors after this
}

}