Conversation
Prevents NullReferenceException if _httpClient was never initialized.
Initial Claude Code setup: root CLAUDE.md documenting SDK architecture, folder structure, build/release workflow, and active skill references. Includes .claude/ config with settings, hooks, skills, and commands.
Implements the 5 trunk XML-RPC actions (createTrunk, updateTrunk, deleteTrunk, getTrunkInfo, getTrunksList) on AccountClient. Adds Trunk model, Request/Response DTOs under Http/Trunk/, ListTrunksRequestBuilder, and wires the TRUNKS region in IAccountClient + AccountClient.
Implements the 5 trunk connection XML-RPC actions (createTrunkConnection, updateTrunkConnection, deleteTrunkConnection, getTrunkConnectionInfo, getTrunkConnectionsList) on AccountClient. Adds TrunkConnection model, Request/Response DTOs under Http/Trunk/, ListTrunkConnectionsRequestBuilder, and wires the TRUNK_CONNECTIONS region in IAccountClient + AccountClient.
Implements createAccount() XML-RPC action with all required and optional fields organized into logical regions (credentials, session/billing, call settings, payment, voicemail, personal info, optional). preferred_codec and on_payment_action are int? to allow explicit null as per the FlySIP API spec. i_routing_group is int? as it is only required for root customer accounts.
Expands AddCustomerRequest with full optional field set from the FlySIP doc (billing, management rights, personal info, features, preferences). UpdateCustomerRequest inherits all new fields automatically. Adds two missing methods: - DeleteCustomerAsync() -> deleteCustomer() - AuthCustomerAsync() -> authCustomer() + AuthCustomerResponse (i_customer, i_web_user, i_access_level)
Creates DidClient with 3 dedicated regions: - DIDS: add, update, delete (by id/number), get (by id/number), list - CHARGING_GROUPS: getDIDChargingGroupInfo - DELEGATIONS: add, update, delete DID delegation Adds Did and DidChargingGroup models, full Http/Did Request/Response DTOs, ListDidsRequestBuilder (extends BaseListRequestBuilder) with fluent filters including NotAssignedOnly().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the FlySharp SDK with full coverage of the Trunks, Trunk Connections, Account creation, Customer, and DID domains from the FlySIP XML-RPC API, plus a defensive dispose fix and Claude Code project setup.
Account Domain
createTrunk,updateTrunk,deleteTrunk,getTrunkInfo,getTrunksList— full models, DTOs, builder, andIAccountClientwiringcreateTrunkConnection,updateTrunkConnection,deleteTrunkConnection,getTrunkConnectionInfo,getTrunkConnectionsListcreateAccountwith full required/optional field set (~80 fields across 6 regions)Customer Domain
AddCustomerRequest/UpdateCustomerRequestto include all FlySIP optional fields (billing, management rights, personal info, features, preferences)DeleteCustomerAsync()→deleteCustomer()AuthCustomerAsync()→authCustomer()withAuthCustomerResponseDID Domain (new standalone client)
DidClientwith three regions: DIDS (add/update/delete/get/list), CHARGING_GROUPS, DELEGATIONS (add/update/delete)DidandDidChargingGroupmodels, fullHttp/DidDTOs, andListDidsRequestBuilderwith fluent filtersInfrastructure & Tooling
nullHttpClientonBaseClient.Dispose()to preventNullReferenceExceptionCLAUDE.mdand.claude/project config (hooks, skills, commands)Test plan
dotnet buildpasses with no warningscd FlySharp.Tester && dotnet run) and verify trunk CRUD calls succeed against FlySIP sandboxcreateAccountwith minimal required fields; confirmBaseResponse.Result == "OK"authCustomerwith valid credentials; confirmAuthCustomerResponsefields populateddeleteCustomerand confirm account is removedNotAssignedOnly()filter; verify pagination (offset/limit)BaseResponseBaseClientinstance with an uninitializedHttpClient; confirm no exception🤖 Generated with Claude Code