feat(render): load an external colour profile via TILE57_COLORPROFILE#22
Merged
Conversation
The render path always used the colour profile embedded in the library. Add a TILE57_COLORPROFILE override — read via the portrayal C shim, mirroring the TILE57_S101_RULES on-disk rules override — so a host can recolour charts from an on-disk colorProfile.xml with no rebuild (e.g. a monochrome "ink" profile for e-ink). sharedColors() (the viewer's render path) and the `tile57 png`/`pdf` tool both honour it; an unset/unreadable path falls back to the embedded profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The render path always used the colour profile embedded in the library. Add a TILE57_COLORPROFILE override — read via the portrayal C shim, mirroring the TILE57_S101_RULES on-disk rules override — so a host can recolour charts from an on-disk colorProfile.xml with no rebuild (e.g. a monochrome "ink" profile for e-ink). sharedColors() (the viewer's render path) and the
tile57 png/pdftool both honour it; an unset/unreadable path falls back to the embedded profile.