Skip to content

api pr workflow#1076

Open
josekudiyirippil wants to merge 94 commits into
mainfrom
josekudiyirippil-patch-10
Open

api pr workflow#1076
josekudiyirippil wants to merge 94 commits into
mainfrom
josekudiyirippil-patch-10

Update pull-request-api.yaml

04ae314
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 8, 2026 in 53s

Quality Gate failed

Failed conditions
5 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 7 in api/sqlalchemy_utc.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "UtcDateTime" to match the regular expression ^[_a-z][_a-z0-9]*$.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKnDvD9yoBsigbNO&open=AZ6oqKnDvD9yoBsigbNO&pullRequest=1076

Check warning on line 37 in api/app/utilities/auth_util.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Fix this attribute access on a value that can be 'None'.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKkpvD9yoBsigbNJ&open=AZ6oqKkpvD9yoBsigbNJ&pullRequest=1076

Check warning on line 138 in api/app/tests/test_availability_service.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "AvailabilityService" to match the regular expression ^[_a-z][a-z0-9_]*$.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKkFvD9yoBsigbNE&open=AZ6oqKkFvD9yoBsigbNE&pullRequest=1076

Check failure on line 180 in api/app/tests/test_schema_compatibility.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKkNvD9yoBsigbNI&open=AZ6oqKkNvD9yoBsigbNI&pullRequest=1076

Check warning on line 80 in api/app/tests/auth/test_internal_only_routes.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the unused local variable "citizen" with "_".

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKjevD9yoBsigbM-&open=AZ6oqKjevD9yoBsigbM-&pullRequest=1076

Check failure on line 105 in api/app/resources/bookings/appointment/appointment_post.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Could not find service for service_id: " 3 times.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKeFvD9yoBsigbM6&open=AZ6oqKeFvD9yoBsigbM6&pullRequest=1076

Check warning on line 160 in api/app/tests/test_availability_service.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "AvailabilityService" to match the regular expression ^[_a-z][a-z0-9_]*$.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKkFvD9yoBsigbNF&open=AZ6oqKkFvD9yoBsigbNF&pullRequest=1076

Check failure on line 245 in api/app/tests/fixtures/db.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKj7vD9yoBsigbNB&open=AZ6oqKj7vD9yoBsigbNB&pullRequest=1076

Check warning on line 234 in api/app/tests/test_availability_service.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "AvailabilityService" to match the regular expression ^[_a-z][a-z0-9_]*$.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKkFvD9yoBsigbNH&open=AZ6oqKkFvD9yoBsigbNH&pullRequest=1076

Check failure on line 24 in notifications-api/src/api/app_config.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "config.ProdConfig" 4 times.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKn_vD9yoBsigbNR&open=AZ6oqKn_vD9yoBsigbNR&pullRequest=1076

Check failure on line 38 in api/app/resources/theq/services.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKhrvD9yoBsigbM7&open=AZ6oqKhrvD9yoBsigbM7&pullRequest=1076

Check warning on line 193 in api/app/tests/test_availability_service.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "AvailabilityService" to match the regular expression ^[_a-z][a-z0-9_]*$.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKkFvD9yoBsigbNG&open=AZ6oqKkFvD9yoBsigbNG&pullRequest=1076

Check warning on line 35 in api/app/utilities/sqlalchemy_compat.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this function so that its implementation is not identical to process_bind_param on line 27.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKkwvD9yoBsigbNK&open=AZ6oqKkwvD9yoBsigbNK&pullRequest=1076

Check warning on line 319 in api/app/tests/fixtures/db.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary `list()` call on an already iterable object.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKj7vD9yoBsigbNC&open=AZ6oqKj7vD9yoBsigbNC&pullRequest=1076

Check warning on line 20 in api/app/utilities/flask_admin_compat.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with dict fromkeys method call

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKlOvD9yoBsigbNL&open=AZ6oqKlOvD9yoBsigbNL&pullRequest=1076

Check warning on line 4 in api/templates/admin/base.html

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add "lang" and/or "xml:lang" attributes to this "<html>" element

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKm7vD9yoBsigbNN&open=AZ6oqKm7vD9yoBsigbNN&pullRequest=1076

Check warning on line 311 in api/app/tests/flows/test_walkin_smartboard_flows.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this comprehension with passing the iterable to the collection constructor call

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKjQvD9yoBsigbM9&open=AZ6oqKjQvD9yoBsigbM9&pullRequest=1076

Check warning on line 112 in api/app/tests/test_availability_service.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "AvailabilityService" to match the regular expression ^[_a-z][a-z0-9_]*$.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKkFvD9yoBsigbND&open=AZ6oqKkFvD9yoBsigbND&pullRequest=1076

Check warning on line 100 in notifications-api/tests/test_config.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this comprehension with passing the iterable to the collection constructor call

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKoJvD9yoBsigbNT&open=AZ6oqKoJvD9yoBsigbNT&pullRequest=1076

Check warning on line 305 in api/app/tests/flows/test_walkin_smartboard_flows.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this comprehension with passing the iterable to the collection constructor call

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKjQvD9yoBsigbM8&open=AZ6oqKjQvD9yoBsigbM8&pullRequest=1076

Check failure on line 44 in api/app/utilities/flask_admin_compat.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=bcgov_queue-management&issues=AZ6oqKlOvD9yoBsigbNM&open=AZ6oqKlOvD9yoBsigbNM&pullRequest=1076