33515 updating the old COOPS outputs to the modern templates#4496
33515 updating the old COOPS outputs to the modern templates#4496vysakh-menon-aot wants to merge 2 commits into
Conversation
vysakh-menon-aot
requested review from
deetz99,
doug-lovett,
kialj876 and
mengdong19
kialj876
left a comment
kialj876
left a comment
There was a problem hiding this comment.
Hey Vysakh, can we condense the templates? It looks like BC and CP are almost the exact same now. All my comments below are to do with that
There was a problem hiding this comment.
It looks like this is the exact same as the bc address layout now? Can we combine cp / bc (add the records if clause here and update bc to use this template / remove 'bc-address-change' folder?
There was a problem hiding this comment.
That was my original plan. Waiting for few UX confirmation regarding the alignment of corps and coop design
There was a problem hiding this comment.
updated to use common template for coop and corps. waiting for UX confirmation on some details, will update accordingly
There was a problem hiding this comment.
same thing for this? It looks like the only differences could be applied to the BC version as well?
There was a problem hiding this comment.
And this too up until line 46?
There was a problem hiding this comment.
And here - exact same as bcAddressChange
There was a problem hiding this comment.
and same here with bcDirectorChange
|
3 participants
Issue #: /bcgov/entity#33515
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).