feat(workflows): print the generated workflow folder after creating a custom workflow - #2025
Conversation
…-1978 # Conflicts: # packages/workflows/CHANGELOG.md
…-1978 # Conflicts: # packages/workflows/CHANGELOG.md
Review result: no blocking findingsCorrection: My first review treated issue #1978 as requiring a new host-side output path. That was too strict for Atomic's current custom-workflow authoring design. Custom workflows are created by the running agent through normal file tools, then reloaded through the workflow tool. There is no separate runtime That differs from workflow-runtime UI such as background launch/connect hints and lifecycle notices, which Atomic generates deterministically. For example:
Within the agent-authored completion layer, this PR uses the established mechanism correctly:
A host-side guarantee would require a new creation API or tracking intent across ordinary file writes, edits, reloads, and agent responses. That would be a larger design change than issue #1978 calls for. Review scope
Real interactive source CLI testtmux target: This was not a smoke test. I ran the source-built interactive Atomic TUI in tmux against a temporary project. The session created a real custom workflow, checked its file on disk, reloaded it, executed its model stage, inspected the completed output, and then ran an existing-workflow control. The source CLI was launched from: Creation and executionAtomic created: The workflow had the requested string input, model stage, and string result. After an initial generated-schema error, Atomic corrected the new workflow, reloaded it, and completed the real run: The final agent response included the expected disclosure exactly once: Resolving that path from the test project matched the actual folder containing the generated workflow file. Existing-workflow controlThe same live CLI then ran the already-created workflow with Within the bounded control output:
This confirms the changed guidance worked in the actual CLI for both the positive creation case and the run-only control. Bun checks
Residual limits
Final verdict: no blocking findings in the reviewed scope. |
|
Thanks @morgan-coded, this has been merged. |
After Atomic creates a custom workflow, the success output never said where the generated code lives — users had to discover the storage location on their own (#1978). Custom workflows are authored by the running agent under model-visible guidance, so this change encodes the disclosure in that tested guidance contract plus the matching docs.
Acceptance criteria covered:
Custom workflow created. You can inspect its code at: <workflow-folder-path>(packages/workflows/src/extension/workflow-prompts.ts: bothWORKFLOW_TOOL_DESCRIPTIONand the authoring section ofDEFAULT_PROMPT_GUIDANCE).Tests:
test/unit/workflow-authoring-folder-disclosure.test.tspins the message shape and the newly-created-only scoping across the tool description, the joined prompt guidance,docs/workflows.md, anddocs/quickstart.md. It follows theexecution-routing-guidancepattern as a separate file because that suite sits at the 500-line file-length gate.Docs: the creation-flow lists in
workflows.mdandquickstart.mdnow end with the folder disclosure step;packages/workflows/README.mdstays byte-synced with the tool description (covered by the existing integration assertion); changelog entry under@bastani/workflowsUnreleased → Added.Closes #1978
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Greptile Summary
Adds model-facing guidance and matching documentation requiring Atomic to report the generated folder after creating a custom workflow.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failures remain.
What T-Rex did
Important Files Changed
Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile