Model Download Code#6
Draft
infil00p wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on the code on fetch Executorch models from an external network
We're using C++ here so that we can switch between TFLite, ONNX Runtime and Executorch so that whatever provides the best user experience for model development can be used here. We use the Kotlin APIs to massage the Javascript data and get it read to be handled by the inference frameworks. This might seem more complicated, BUT if we use Java APIs we're locking ourselves to the JNI implementations.
Since we're in 2024, and since TFLite STILL can't export a modern PyTorch model, we're going with Executorch for ease of use. Fiddling with frameworks at this point is pointless and redundant.