Cleanup metadata

[jared321]

PR Self-review

• Review all changes
• Build sdist and wheel
  • Confirm that license specification warning is not printed during build
  • Confirm that for each distribution the license is still provided and metadata is correct
• Spot check action logs and confirm no sign of license specification warning
• Confirm all actions passing

[jared321]

@mosesyhc Can you please review the changes made so far in this PR and finalize in this PR the full set of metadata classifiers in setup.py? The current set of valid classifiers at here.

[mosesyhc]

The changes look good to me. Two minor questions:

1. Do we not need the MIT license classifier because of the license field?
2. Do we need the Framework :: tox classifier? Is it useful at all?

[jared321]

Do we not need the MIT license classifier because of the license field?

The removal of this specific classifier was suggested in many action logs as part of building distributions

********************************************************************************
Please consider removing the following classifiers in favor of a SPDX license expression:

License :: OSI Approved :: MIT License

See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
********************************************************************************

Naively I suspect that the main goal is for packages to specify the license in only one place.

Do we need the Framework :: tox classifier? Is it useful at all?

Good question. I would guess not since this package does not provide any functionality to the tox world nor does it provide any functionality to package users directly via tox. Rather tox is something that developers access behind the scenes through clones of the surmise repo.

Do you want people to find surmise by filtering out only those packages in PyPI that mention tox in their metadata?

[mosesyhc]

Thanks for the background info on the license.

I agree the addition of tox does not add much value. We can leave it out.