Remove OleAut32.lib#9
Open
reinismu wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks, I will check it out soon. |
Bindgen 0.69's libclang behavior on macOS produced opaque structs (just _address: u8) for bw_Application, bw_Window, and bw_BrowserWindow when cross-compiling to x86_64-pc-windows-msvc, breaking Rust accesses like (*window).user_data and (*bw).impl_.controller. Bumping to 0.72 fixes the opaque-struct regression. Removing -DBW_BINDGEN lets bindgen include the platform impl headers (application/win32.h, browser_window/edge2.h) so the Rust-side struct layouts match what cc::Build produces. Callers cross-compiling on a non -Linux host need to point bindgen at Windows headers via BINDGEN_EXTRA_CLANG_ARGS_x86_64_pc_windows_msvc (e.g. xwin's SDK cache). Updated ParseCallbacks::item_name to bindgen 0.70+'s ItemInfo signature. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not 100% confident, but it seems we dont need it. It now allows me to build with
cargo xwin build --target x86_64-pc-windows-msvcon linux fro windows edge2