[WIP] The implement-review loop can run indefinitely if the reviewer keeps req - #286
Closed
bamdadd wants to merge 1 commit into
Closed
[WIP] The implement-review loop can run indefinitely if the reviewer keeps req#286bamdadd wants to merge 1 commit into
bamdadd wants to merge 1 commit into
Conversation
Owner
Author
|
Closing stub PR — superseded by PR #288 with actual implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforce MAX_REVIEW_CYCLES in the implement-review loop by adding a force_approve node and cycle guard in route_after_review, making the limit configurable per-project (default 3), emitting a ReviewCycleLimitReached guardrail event, annotating the PR with a warning, and tracking cycle counts in pipeline stage metadata.
Changes
Context
Implementation:
Raised by Lintel 🤖