Filter sport type - #987
Open
kohloderso wants to merge 6 commits into
Open
Conversation
The type is returned by the filter API but had no translation, so it rendered as an unlabelled checkbox in the filter dialog. Fixes #986
Hochtour was missing from tourTypes, so the lookup fell through to the raw database value and showed German in every language.
Collaborator
Author
|
You can deploy the changes on dev without them having to be on the dev branch: 
|
Merged
Keeps the documented sport types in sync with the Trailrunning type added elsewhere in this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #986