⚡ Bolt: Optimized unique random number generation in random.html#97
⚡ Bolt: Optimized unique random number generation in random.html#97babelman97 wants to merge 1 commit into
Conversation
Identified and resolved a performance bottleneck in `random.html` where high-density unique random sampling caused significant slowdowns due to rejection sampling collisions. Key Changes: - Implemented a hybrid sampling algorithm: Rejection Sampling (Set) for low density and Sparse Fisher-Yates (Map) for high density. - Optimized DOM updates by switching from `innerText` to `textContent`. - Improved UI responsiveness for large data sets by adding a scrollable, text-wrapped results container. - Fixed a bug in range validation that prevented single-value ranges. - Performance: Logic-specific execution for 1M numbers improved by ~10x-20x (~2.2s -> ~0.4s). Total browser time for 1M numbers reduced from ~9.4s to ~7.2s. Co-authored-by: babelman97 <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What:
Optimized the unique random number generation in
random.htmlby implementing a hybrid sampling strategy.🎯 Why:
The previous implementation used rejection sampling (Set-based), which suffers from the "Coupon Collector's Problem." As the requested count approaches the total range size, collisions become frequent, leading to$O(N^2)$ or worse performance. Generating 999,999 numbers in a 1,000,000 range took ~9.4 seconds.
📊 Impact:
textContentand a scrollable container prevents layout thrashing and browser hangs during large-scale rendering.🔬 Measurement:
Verified using a Playwright benchmarking script (
bench_random.py) and functional correctness tests. UI was verified via screenshots for responsiveness.PR created automatically by Jules for task 17765495913489135352 started by @babelman97