⚡ Bolt: Optimized random number sampling algorithm#86
Conversation
- Implemented hybrid sampling: Set-based rejection for <50% density, Fisher-Yates shuffle for >=50% density. - Optimized performance for high-density requests from O(N²) to O(N). - Fixed validation bug to allow single-value ranges (minValue == maxValue). - Enhanced UI with scrollable results container to prevent layout thrashing. - Added performance safety cap of 10,000,000 for range size. Co-authored-by: babelman97 <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
The random number generator in
random.htmlpreviously used rejection sampling for all requests. This caused a significant performance bottleneck when the number of requested unique values was close to the total range size (the "Coupon Collector's Problem"), leading to O(N²) complexity and browser hangs.I implemented a hybrid sampling algorithm:
Set-based rejection sampling, which is memory-efficient for sparse selections.Measurable Impact:
Additional Improvements:
max-height: 50vh,overflow-y: auto, andword-break: break-allto the#randomNumberscontainer. This ensures the page remains usable even when generating thousands of numbers.minValue >= maxValuetominValue > maxValueto allow generating a single number from a range of one (e.g., [5, 5]).PR created automatically by Jules for task 11485824570039336950 started by @babelman97