⚡ Bolt: Optimized unique random sampling in random.html#84
Conversation
- Implement hybrid sampling strategy: Fisher-Yates for high density, Set-based rejection for low density. - Replace innerText with textContent for faster DOM updates. - Add CSS overflow and max-height to results container to handle large outputs. - Fix validation logic to allow single-value ranges. Co-authored-by: babelman97 <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Implemented a hybrid sampling strategy for unique random number generation in
random.html. Added CSS overflow handling and switched totextContentfor DOM updates.🎯 Why: The previous implementation used rejection sampling (a Set-based
whileloop), which suffers from the "Coupon Collector's Problem" when the requested count is close to the range size (high density). This caused the browser to hang or become sluggish. Additionally, the UI would break with large number sets.📊 Impact:
🔬 Measurement:
PR created automatically by Jules for task 4659653597757448011 started by @babelman97