⚡ Bolt: optimize unique random number generation in random.html#107
⚡ Bolt: optimize unique random number generation in random.html#107babelman97 wants to merge 1 commit into
Conversation
- Implemented hybrid sampling: Rejection Sampling for low density (<50%), Sparse Fisher-Yates (Map-based) for high density (>=50%). - Improved logic performance by ~4.8x for high-density requests (999k in 1M range). - Fixed range validation bug to allow single-value ranges (e.g., [5, 5]). - Added CSS layout optimizations (max-height, scrolling, word-wrap) to handle large outputs gracefully. - Documented performance impact in code comments. Co-authored-by: babelman97 <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR optimizes the unique random number generation in
random.htmlby replacing the inefficient rejection sampling approach with a hybrid algorithm.💡 What
Mapfor high-density requests (where requested count > 50% of range).minValue === maxValue.#randomNumbersto handle large outputs without breaking the page layout.🎯 Why
The original algorithm used rejection sampling for all cases. While efficient at low densities, it suffers from the "birthday problem" collision overhead as density increases, leading to$O(N^2)$ or worse performance. For 999,999 numbers in a 1,000,000 range, this was causing significant browser hangs.
📊 Impact
🔬 Measurement
Verified using a Playwright benchmarking script comparing
performance.now()before and after thegenerateRandomNumbers()call. Tested across various densities and range sizes.PR created automatically by Jules for task 5071550667372668664 started by @babelman97