Skip to content

⚡ Bolt: optimize unique random number generation in random.html#100

Open
babelman97 wants to merge 1 commit into
mainfrom
bolt-optimize-random-sampling-929274529676734042
Open

⚡ Bolt: optimize unique random number generation in random.html#100
babelman97 wants to merge 1 commit into
mainfrom
bolt-optimize-random-sampling-929274529676734042

Conversation

@babelman97

Copy link
Copy Markdown
Owner

💡 What: Optimized the unique random number generation logic and UI in random.html.
🎯 Why: The previous implementation used rejection sampling for all cases, which leads to extreme collisions and O(N²) behavior when the requested count is close to the range size (e.g., 1M numbers in 1M range).
📊 Impact: Internal JS execution for 1,000,000 numbers reduced to ~416ms. Total browser processing (including DOM string overhead) reduced from ~8s to ~5.6s.
🔬 Measurement: Verified using Playwright benchmarks (bench_random.py) and correctness tests (verify_random.py). UI verified via Playwright screenshots.


PR created automatically by Jules for task 929274529676734042 started by @babelman97

- Implement hybrid sampling algorithm: Rejection Sampling (<50% density) and Sparse Fisher-Yates (>=50% density) for O(count) performance.
- Switch to `textContent` for faster DOM updates by avoiding redundant layout reflows.
- Add robust input validation and a 10M range limit to prevent browser memory exhaustion.
- Improve UI responsiveness for large datasets with a scrollable, constrained result container.
- Verified performance improvement: Internal JS logic for 1M numbers optimized to ~416ms.

Co-authored-by: babelman97 <[email protected]>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant