fix(PlayerMethods): corrected SetSkill argument order

[Aldori15]

Summary

Fixes Player:SetSkill argument forwarding in ALE.

AzerothCore core expects:

// Player.h
void SetSkill(uint16 id, uint16 step, uint16 currVal, uint16 maxVal);

// Player.cpp
void Player::SetSkill(uint16 id, uint16 step, uint16 newVal, uint16 maxVal)

ALE was reading the Lua arguments in that order, but forwarding them incorrectly here:

uint16 step = ALE::CHECKVAL<uint16>(L, 3);
uint16 currVal = ALE::CHECKVAL<uint16>(L, 4);
uint16 maxVal = ALE::CHECKVAL<uint16>(L, 5);

player->SetSkill(id, currVal, maxVal, step);

And according to the documentation, it matches the expectation from the Core. So this caused Lua calls like this to pass the values into the core as the wrong fields:

player:SetSkill(skillId, step, currentVal, maxVal)

Fix

• Forward the arguments in the correct order as expected by AzerothCore

Summary by CodeRabbit

• Bug Fixes
  • Corrected skill updates so the current value, maximum value, and step are now applied in the proper order.
  • This helps ensure skill changes made through Lua behave as expected in-game.

[coderabbitai]

📝 Walkthrough

Walkthrough

The SetSkill Lua binding in PlayerMethods.h now calls Player::SetSkill with arguments reordered to (id, step, currVal, maxVal) instead of (id, currVal, maxVal, step).

Changes

SetSkill Argument Order Fix

Layer / File(s)	Summary
Reorder SetSkill call arguments src/LuaEngine/methods/PlayerMethods.h	The player->SetSkill(...) call now passes arguments as (id, step, currVal, maxVal) instead of (id, currVal, maxVal, step).

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: correcting SetSkill argument order in PlayerMethods.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}