feat(Core/Chat): new argument parsing and unify chat hyperlink parsing

[Winfidonarleyan]

Changes Proposed:

• [3.3.5] Unify chat link parsing TrinityCore/TrinityCore#22417
• Scripts/Commands: New argument parsing class TrinityCore/TrinityCore#22363

Issues Addressed:

• Closes Feature(Core/Chat); Rework argument parsing methodology and unify chat link parsing [$100] #6112

Tests Performed:

How to Test the Changes:

0. Change config option ChatFakeMessagePreventing to 1
1. Check all game links (spells, items and etc)
2. Check core commands (most)
3. Check with feat(DBC): correct dbcstructure interfacing mod-transmog#48
4. Check ticket system
5. Check chat (say and other)
6. Check ItemRandomProperties and ItemRandomSuffix

Known Issues and TODO List:

• feat(DBC): correct dbcstructure interfacing mod-transmog#48
• chore(Commands): ignore new chatcommand functions mod-ah-bot#44
• https://github.com/azerothcore/Eluna/pull/6

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Winfidonarleyan]

Ready

[FrancescoBorzi]

@azerothcore/testers @azerothcore/modules @azerothcore/developers @azerothcore/senior-bug-triaging can anyone please check this?

[Winfidonarleyan]

👀

[IntelligentQuantum]

@Winfidonarleyan Works fine for me.

[Winfidonarleyan]

@Winfidonarleyan Works fine for me.

and all modules ?

[IntelligentQuantum]

@Winfidonarleyan Works fine for me.

and all modules ?

We need someone to test ahbot.

[Winfidonarleyan]

@Winfidonarleyan Works fine for me.

and all modules ?

We need someone to test ahbot.

how to test this module?

[IntelligentQuantum]

@Winfidonarleyan Works fine for me.

and all modules ?

We need someone to test ahbot.

how to test this module?

idk ..

[Winfidonarleyan]

Okay, need test only modules

[IntelligentQuantum]

@azerothcore/modules @azerothcore/testers

[Winfidonarleyan]

Test with modules

• Transmog
  
• Auction
  This module is not modified and works on the old API

[Winfidonarleyan]

@IntelligentQuantum What do you think, is there anything else to check?

[IntelligentQuantum]

@IntelligentQuantum What do you think, is there anything else to check?

No, we can merge it

• Link Uncommon, Rare, Epic and .... Items
• Link Achievement
• Link talent spell
• Update Ticket
• /yell, say, p .....
• commands

and .....

[Winfidonarleyan]

@IntelligentQuantum What do you think, is there anything else to check?

No, we can merge it

• Link Uncommon, Rare, Epic and .... Items
• Link Achievement
• Link talent spell
• Update Ticket
• /yell, say, p .....
• commands

and .....

Okay, thanks

[Kitzunu]

conflict

[Winfidonarleyan]

@FrancescoBorzi Thanks :D