fix(DB/Spell): Fix Omen of Clarity not proccing from utility spells

[blinkysc]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Reverts SpellTypeMask from 3 to 0 for Omen of Clarity (16864), matching TrinityCore. SpellTypeMask=3 blocked magic-class utility spells like Gift of the Wild and Mark of the Wild from triggering OoC.

Regression from #24233.

AI-assisted Pull Requests

Important

While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.

Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.

• AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Claude Code with azerothMCP.

Issues Addressed:

• Closes

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). TrinityCore spell_proc for 16864 uses SpellTypeMask=0.

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. Learn Omen of Clarity on a druid
2. Cast Gift of the Wild or Mark of the Wild on a target
3. Verify Clearcasting can proc

Known Issues and TODO List:

• Verify no unintended triggered spells proc OoC

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Apathyxia]

Tested. This is how it works with this PR:

Omen Procs

Spell / Ability	Does it proc Omen?
Barkskin	Yes
Cyclone	Yes
Entangling Roots	Yes
Faerie Fire	Yes
Hibernate	Yes
Hurricane	Yes
Innervate	Yes
Moonfire	Yes
Nature's Grasp	Yes
Soothe Animal	No
Starfire	Yes
Teleport: Moonglade	Yes
Thorns	Yes
Wrath	Yes
Abolish Poison	Yes
Cure Poison	Yes
Gift of the Wild	Yes
Healing Touch	Yes
Lifebloom	Yes
Mark of the Wild	Yes
Nourish	Yes
Rebirth	Yes
Regrowth	Yes
Rejuvenation	Yes
Remove Curse	Yes
Revive	Yes
Tranquillity	Yes
Basic attacks	Yes
Rake	No
Claw	No
Mangle (cat)	No
Ferocious Bite	No
Shred	No
Swipe (cat)	No
Tiger's Fury	No
Savage Roar	No
Dash	No
Prowl	No
Rip	No
Berserk	No
Surival Instincts	No
Shapeshifting	No
Mangle (bear)	No
Maul	No
Lacerate	No
Demoralizing Roar	Yes
Faerie Fire (feral) (bear)	Yes
Faerie Fire (feral) (cat)	Yes
Feral Charge (bear)	Yes
Feral Charge (cat)	No
Improved Leader of the Pack	No
Swipe (bear)	No
Ravage	No
Maim	No
Starfall	Yes
Insect Swarm	Yes
Typhoon	Yes
Force of Nature	No
Wild Growth	Yes

Did I miss something? Sorry about the order of spells; it's just the order I tested them in.
There are probably some spells where the behaviour is wrong, but I'm not entirely sure which spell should and which shouldn't proc it.

[bonfax4]

Still missing the Predators swiftness + spell behavior right ? It should have a 50-60% chance to proc when a spell is used with it. Theory was it used predators swiftness duration ( 10 secs ) as the "cast time". This was also added to classic wotlk. ( 3.5/60 * 10 = 58.3%)

Proof here

[blinkysc]

Still missing the Predators swiftness + spell behavior right ? It should have a 50-60% chance to proc when a spell is used with it. Theory was it used predators swiftness duration ( 10 secs ) as the "cast time". This was also added to classic wotlk. ( 3.5/60 * 10 = 58.3%)

Proof here

Let me revisit this in another PR so I can merge this for now

EDIT: @bonfax4 cast time it is already in the calculation thanks to @Tereneckla

[bonfax4]

Still missing the Predators swiftness + spell behavior right ? It should have a 50-60% chance to proc when a spell is used with it. Theory was it used predators swiftness duration ( 10 secs ) as the "cast time". This was also added to classic wotlk. ( 3.5/60 * 10 = 58.3%)
Proof here

Let me revisit this in another PR so I can merge this for now

EDIT: @bonfax4 cast time it is already in the calculation thanks to @Tereneckla

Not what I ment exactly. Its for instant casts with predators swiftness specifically, doesn't use cast time exactly, it just has a higher chance to proc. Its like @ 60%.