[feat] examples: Add linked-list backed stack#213
Open
ethan-kharitonov wants to merge 1 commit into
Open
Conversation
| lemma prism_embed_iso_prism_id [simp]: \<open>prism_embed (iso_prism id id) = id\<close> | ||
| by (auto simp: iso_prism_def) | ||
|
|
||
| lemma gref_map_id [simp]: \<open>gref_map id = id\<close> |
Collaborator
There was a problem hiding this comment.
nit: please use shows when expressing lemma statements and match the prevailing style.
| shows \<open>\<Gamma>; push s x \<Turnstile>\<^sub>F push_contract s x ts\<close> | ||
| apply (crush_boot f: push_def contract: push_contract_def) | ||
| apply (clarsimp simp add: stack_points_to_def) | ||
| apply crush_base |
Collaborator
There was a problem hiding this comment.
nit: can the two lines not be collapsed into:
apply (crush_base simp add: ll_focus_node_prism aentails_refl is_valid_ref_for_def)
| shows \<open>\<Gamma>; pop s \<Turnstile>\<^sub>F pop_contract s ts\<close> | ||
| apply (crush_boot f: pop_def contract: pop_contract_def) | ||
| apply (cases ts; clarsimp simp add: stack_points_to_def ll_points_to_None asepconj_simp) | ||
| apply (crush_base split!: option.splits)+ |
Collaborator
There was a problem hiding this comment.
nit: additional space here of indentation. Is the + needed, also?
| shows \<open>\<Gamma>; is_empty s \<Turnstile>\<^sub>F is_empty_contract s ts\<close> | ||
| apply (crush_boot f: is_empty_def contract: is_empty_contract_def) | ||
| apply (cases ts; clarsimp simp add: stack_points_to_def ll_points_to_None asepconj_simp) | ||
| apply (crush_base split!: option.splits)+ |
Collaborator
There was a problem hiding this comment.
nit: same comment as above.
| \<theta> = \<open>\<lambda>_. \<langle>False\<rangle>\<close> | ||
| in wp_raw_for_loop_framedI' | ||
| \<close>) | ||
| subgoal by crush_base |
Collaborator
There was a problem hiding this comment.
Can these two subgoal commands not just be replaced with a single apply (crush_base simp add: take_Suc_conv_app_nth)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: Adds a stack uRust type built on top of the existing linked-list implementation.
stacklocale withstack_points_topredicate and verifiedempty,push,pop,is_empty, andpush_alloperations.Tested:
isabelle build -d . Micro_Rust_Examples.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.