Skip to content

add queue wait histogram, oldest queued age, in-flight cache#29

Merged
aviator-app[bot] merged 10 commits into
mainfrom
metrics-correlation
Apr 28, 2026
Merged

add queue wait histogram, oldest queued age, in-flight cache#29
aviator-app[bot] merged 10 commits into
mainfrom
metrics-correlation

Conversation

@tulioz

@tulioz tulioz commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

closes queue-wait and stuck-task blindspots

@aviator-app

aviator-app Bot commented Apr 24, 2026

Copy link
Copy Markdown

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

Stack


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds tracking for in-flight Celery tasks to monitor queue wait times and the age of the oldest queued tasks, introducing new Prometheus metrics and CLI configuration for cache management. The implementation includes logic to handle task lifecycle events and manage an in-flight task cache. Feedback focused on potential performance bottlenecks during metric collection from the large cache and suggested an optimization for the TTL check using the chronological properties of the data structure.

Comment thread celerymon/event_watcher.py Outdated
Comment thread celerymon/event_watcher.py
@tulioz tulioz force-pushed the metrics-correlation branch from 1ef918f to 7daa335 Compare April 24, 2026 17:33
@tulioz tulioz force-pushed the metrics-easy-wins branch from 4991434 to 998471f Compare April 24, 2026 20:25
@tulioz tulioz force-pushed the metrics-correlation branch from 7daa335 to 251d0a0 Compare April 24, 2026 20:36
@tulioz tulioz force-pushed the metrics-correlation branch 2 times, most recently from 40e63c0 to dcf687d Compare April 28, 2026 21:00
@tulioz tulioz force-pushed the metrics-correlation branch from dcf687d to 8d86f95 Compare April 28, 2026 22:44
@tulioz tulioz force-pushed the metrics-correlation branch from 405ed0f to 00c8199 Compare April 28, 2026 23:43
@aviator-app aviator-app Bot changed the base branch from metrics-easy-wins to main April 28, 2026 23:53
@aviator-app aviator-app Bot merged commit 977ccfe into main Apr 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants