Fix: Convert Inline Styles to Tailwind CSS#449
Open
svarcoder wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| class="legend-dot" | ||
| style="background-color: var(--primary)" | ||
| ></div> | ||
| <div class="legend-dot bg-[var(--primary)]"></div> |
Collaborator
There was a problem hiding this comment.
@svarcoder add these var values to tailwind config and use something like example bg-primary-100 or something
Collaborator
There was a problem hiding this comment.
Do this for all the variables
Contributor
Author
There was a problem hiding this comment.
Ok.I am doing that.
Contributor
Author
There was a problem hiding this comment.
Fixed That in All File. Please Check
Contributor
There was a problem hiding this comment.
Some Reviews for the Issue as a Whole
- Remove Every Custom/Hardcoded Style Value in the Tailwind.
- Update the Tailwind Config up to our requirements to optimise the Styling Code that we write, i.e Height, Padding, Typography and Color Schemes etc
- Remove The Inline CSS Mods added to the UI Components.
- Update or Replace the Pre Existing PNGs to modern image formats (SVGs, WebPs)
- Remove any Redundant or Unused Code or Components.
…mize Tailwind Config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Convert Inline Styles to Tailwind CSS
Resolves or continues AR-8189.
Changes
Convert Inline Styles to Tailwind CSS
Checklist
developer/AR-XXX-issue-name.