issues-fixed#169
Merged
Merged
Conversation
…RuleByName Rationale: It's a lookup-and-compile by identifiers, not by model. 2. *CompileRule(Rule rule, RuleExpressionType, ...)* → CompileRuleInternal or CompileRuleModel Rationale: This is the thin wrapper around _ruleCompiler.CompileRule. I'd lean toward CompileRuleModel to indicate it takes a Rule model, but CompileRuleInternal also works since it's private and just delegates. 3. *CompileRuleWithRuleResults(...)* → CompileRuleWithReferences or CompileReferencedRule Rationale: "RuleResults" is misleading — it's actually handling references to other rules' results and success events. CompileRuleWithReferences captures both. 4. *GetCompiledRule(...)* (bonus) → GetOrCompileRule Rationale: It checks cache first, then falls back to compilation. "GetOrCompile" is more honest about what it does.
Simpler, clearer code
…caching fixed that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
many changes made which will improve speed significantly