Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(sys): astrid:[email protected] superset adding capsule-set-epoch #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(sys): astrid:[email protected] superset adding capsule-set-epoch #18
Changes from all commits
0e9e53cec21510File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returning a magic value of
0when the registry is momentarily unavailable can lead to correctness issues. If a client starts up with an uninitialized or empty cache (which often defaults to0or is represented as0), and the registry is temporarily unavailable, the host will return0. The client will compare the returned0with its cached0, assume they match, and skip the initial cache population, leading to a silent failure.\n\nUsingoption<u64>instead of a magic0allows the client to explicitly handle the unavailable state (e.g., by retrying or keeping the existing cache) without risking a false match with an uninitialized state.Uh oh!
There was an error while loading. Please reload this page.