Prepare setup-astrid v2 release#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Prepares setup-astrid for a v2 major tag by extracting the Sigstore workflow-identity verification logic into a reusable script, adding regression coverage for identity-policy behavior, and updating documentation for the v1→v2 boundary and signed-tag release procedure.
Changes:
- Extracted Sigstore certificate identity verification into
scripts/verify-release-identity.shand invoked it from the composite action. - Added a deterministic policy test harness (
scripts/test-release-identity.sh) and a CI job to validate canonical, legacy, fork, override, and failure paths. - Documented the v2 signed-tag release procedure (
RELEASING.md) and repaired/expanded README inputs + v1→v2 guidance.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
scripts/verify-release-identity.sh |
New reusable identity verification script with narrow legacy fallback only for the canonical repo. |
scripts/test-release-identity.sh |
Adds policy regression tests via a fake cosign to validate identity selection and fallback behavior. |
RELEASING.md |
Documents signed immutable v2.x.y + moving v2 tag procedure and post-merge steps. |
README.md |
Fixes inputs table layout and documents v1→v2 boundary + identity behavior. |
action.yml |
Replaces inline cosign identity verification with a call to the new script using github.action_path. |
.github/workflows/test.yml |
Adds a CI job to run the identity-policy regression test script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare the canonical Astrid Runtime setup action for its v2 tag without publishing that tag before review and merge.
Changes
astrid-runtime/astrididentity and historicalunicity-astrid/astridrelease identity.v2.0.0and movingv2.Impact
The README's
astrid-runtime/setup-astrid@v2examples become publishable from the reviewed main commit. Existing v1 consumers remain untouched.Verification
scripts/test-release-identity.shbash -n scripts/verify-release-identity.sh scripts/test-release-identity.shshellcheck scripts/verify-release-identity.sh scripts/test-release-identity.shaction.ymland.github/workflows/test.ymlwith Ruby YAML.git diff --checkPost-merge release step
Do not create the tags from this branch. After this PR is merged and
mainis green, followRELEASING.mdto sign and atomically pushv2.0.0andv2, then dispatchtest.ymlagainstv2.