Skip to content

docs(sdk): reference the [subscribe] handler form, not [[interceptor]]#59

Merged
joshuajbouw merged 1 commit into
mainfrom
docs/interceptor-subscribe-handler
Jun 16, 2026
Merged

docs(sdk): reference the [subscribe] handler form, not [[interceptor]]#59
joshuajbouw merged 1 commit into
mainfrom
docs/interceptor-subscribe-handler

Conversation

@joshuajbouw

Copy link
Copy Markdown
Contributor

Updates the interceptors module doc comments (interceptors.rs, lib.rs) from the removed [[interceptor]] manifest block to the current [subscribe] entry with a handler (astrid#863). Doc-only — the SDK never parsed Capsule.toml.

Supersedes #52, which carried a regressive contracts-submodule downgrade to an old wit feat-branch commit; this re-does just the doc fix cleanly on current main.

The [[interceptor]] manifest block was replaced by a [subscribe] entry with a
handler (astrid#863). Update the interceptors module doc comments to the
current form. Doc-only; the SDK never parsed Capsule.toml. (Re-does #52 on
current main without its stale contracts-submodule downgrade.)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in astrid-sdk/src/interceptors.rs and astrid-sdk/src/lib.rs to clarify that auto-subscribed interceptors require both run() and a [subscribe] entry with a handler, replacing the outdated reference to [[interceptor]]. There are no review comments, and the changes look correct, so I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@joshuajbouw joshuajbouw merged commit d4ae02e into main Jun 16, 2026
8 checks passed
@joshuajbouw joshuajbouw deleted the docs/interceptor-subscribe-handler branch June 16, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant