feat(core): populate passive capability-registry revision 1#1252
Open
joshuajbouw wants to merge 9 commits into
Open
feat(core): populate passive capability-registry revision 1#1252joshuajbouw wants to merge 9 commits into
joshuajbouw wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR populates the previously-frozen passive capability-registry revision 1 by assigning fixed authorization semantics (scope, target kinds, delegability, privileged status, provenance) to the 51 normative capability IDs, and adds drift-gating tests to ensure kernel/admin enforcement mappings and role classifications cannot diverge from the registry.
Changes:
- Introduces a typed revision-1 registry manifest builder in
astrid-core, including fixed semantics and explicit errors for missing definitions/metadata. - Updates kernel drift tests to validate that all kernel/admin required-capability mappings resolve to registered revision-1 entries, and that every revision-1 ID has exactly one enforcement-role classification.
- Extends request-variant inventories (kernel + admin) and adds golden digest-vector tests to freeze per-entry and aggregate registry digests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/astrid-kernel/src/kernel_router/capability_catalog_tests.rs | Switches drift checks from catalog coverage to registry-revision coverage; adds enforcement-role classification completeness test. |
| crates/astrid-kernel/src/kernel_router/admin/tests.rs | Expands admin request-variant inventory to include newer variants for mapping/exhaustiveness tests. |
| crates/astrid-core/src/capability_registry/tests.rs | Adds tests asserting revision-1 registry definitions, preserved catalog metadata, and stable per-entry + aggregate digests. |
| crates/astrid-core/src/capability_registry.rs | Implements revision-1 registry manifest construction with fixed semantics and display metadata resolution; adds new error variants. |
| CHANGELOG.md | Documents the revision-1 capability-registry semantic population under [Unreleased]. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #1235
Refs #1228, #1233, #1234, and astrid-runtime/rfcs#36.
Summary
Populates the passive 51-entry capability-registry revision 1 on top of the
primitives merged in #1234. Existing authorization, wildcard evaluation,
persisted state, socket behavior, and wire contracts remain unchanged.
Changes
privileged status, source, and display danger
dormant, or mapping-only
Adding a future live capability remains supported. The catalog/count/mapping
checks fail until a new registry revision is introduced; revision 1 itself is
never silently expanded.
Verification
cargo fmt --all -- --checkcargo metadata --locked --offline --no-deps --format-version 1git diff --check origin/main..HEADregenerating every domain-separated BLAKE3 vector with
b3sumce515d915f9dc964preserves every existingAuthorityRegistryErrordiscriminant; public-API compatibility is rerunningChecklist
[Unreleased]