fix: disable production source maps#20
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #19 by preventing production source maps from being generated and by tightening static output verification to ensure no .map artifacts are present in either the client staging output or the final dist tree.
Changes:
- Disable Vite production build source maps (
build.sourcemap: false). - Extend
verify-static-outputto fail verification if any.mapfiles are found underdistor.askr/client.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vite.config.ts | Disables production source map generation for the Vite client build. |
| scripts/verify-static-output.ts | Adds recursive scanning to reject any .map files in staging and final static output directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19.
Disables Vite production source maps and extends static verification to reject every .map artifact in both .askr/client and the final dist tree.
Full local npm run check passes: formatting, lint, types, docs drift, 12 unit tests, client build with no map outputs, 338-route SSG build, and static verification with 32,442 API anchors.