fix: remove production analytics scripts#18
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes third-party production analytics from the shared HTML shell and strengthens the static-output verification step to ensure generated routes don’t reintroduce external executable scripts or the removed analytics bootstrap.
Changes:
- Removed Google Tag Manager loader and inline
dataLayerbootstrap fromindex.html. - Added static verification assertions to fail builds that include external script
srcURLs or analytics markers in generated HTML.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/verify-static-output.ts | Adds new static-output assertions to detect external executable scripts and removed analytics remnants. |
| index.html | Removes Google Tag Manager and inline analytics bootstrap from the base HTML shell. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
Removes the Google Tag Manager loader and inline dataLayer bootstrap from the shared HTML shell. Static verification now rejects external executable script URLs and the removed analytics markers on every generated route.
Full local npm run check passes: formatting, lint, types, docs drift, 12 unit tests, client build, 338-route SSG build, and static verification with 32,442 API anchors.