Skip to content

fix: restore Askr typography and navbar alignment#16

Merged
smiggleworth merged 1 commit into
mainfrom
fix/website-askr-font
Jul 26, 2026
Merged

fix: restore Askr typography and navbar alignment#16
smiggleworth merged 1 commit into
mainfrom
fix/website-askr-font

Conversation

@smiggleworth

@smiggleworth smiggleworth commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • restore the existing Askr Domine heading font at the shared site-shell boundary
  • align the docs search control with the desktop navbar and use the shared outline button treatment
  • place the docs channel in the same Container size="xl" boundary as the header and marketing content
  • port the Cntryl search fixes for delegated input targets, stable dialog rendering, and lifecycle-managed shortcuts
  • update all outdated direct Askr packages (askr 0.0.70, themes 0.0.16, testing 0.0.2) and regenerate versioned API docs

Verification

  • npm run check
    • formatting, lint, typecheck, and docs drift checks passed
    • 12 unit tests passed
    • production SSG generated 338/338 routes
    • static verification passed for 338 routes and 32,442 API anchors
  • npm outdated --json reports no outdated direct @askrjs/* packages
  • generated docs markup gives the header and docs channel the same themed container layout class
  • restarted dev server returns HTTP 200 for /docs/ using the updated lockfile
  • no runtime errors appeared after the search fix hot reloaded

The browser connector is unavailable in this session, so interactive visual confirmation is being performed against the live local dev server.

Closes #15

Copilot AI review requested due to automatic review settings July 26, 2026 10:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores Askr’s typography and improves docs navbar search alignment/behavior to match the shared site-shell styling and avoid client-side search rendering errors.

Changes:

  • Applies the existing Domine Variable heading font token at the shared .site-shell boundary and centralizes the docs secondary text token.
  • Aligns the docs search control with the desktop navbar by removing sidebar spacing and ensuring truncation works in a flex layout.
  • Normalizes potentially-unset search query state to avoid .trim() throwing, and switches the trigger to the shared outline Button.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/styles.css Moves shared typography tokens to .site-shell, removes navbar search margin, and adjusts search trigger layout/truncation styles.
src/pages/docs/search.tsx Updates the search trigger to use themed Button and guards query rendering/searching against undefined.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@smiggleworth
smiggleworth force-pushed the fix/website-askr-font branch from cfbaffd to b9f5ef1 Compare July 26, 2026 10:35
@smiggleworth
smiggleworth force-pushed the fix/website-askr-font branch from b9f5ef1 to a7ccab4 Compare July 26, 2026 10:44
@smiggleworth
smiggleworth merged commit ce9ba89 into main Jul 26, 2026
1 check passed
@smiggleworth
smiggleworth deleted the fix/website-askr-font branch July 26, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: preserve Askr typography and align navbar search

2 participants