fix: restore Askr typography and navbar alignment#16
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Restores Askr’s typography and improves docs navbar search alignment/behavior to match the shared site-shell styling and avoid client-side search rendering errors.
Changes:
- Applies the existing
Domine Variableheading font token at the shared.site-shellboundary and centralizes the docs secondary text token. - Aligns the docs search control with the desktop navbar by removing sidebar spacing and ensuring truncation works in a flex layout.
- Normalizes potentially-unset search query state to avoid
.trim()throwing, and switches the trigger to the shared outlineButton.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/styles.css | Moves shared typography tokens to .site-shell, removes navbar search margin, and adjusts search trigger layout/truncation styles. |
| src/pages/docs/search.tsx | Updates the search trigger to use themed Button and guards query rendering/searching against undefined. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smiggleworth
force-pushed
the
fix/website-askr-font
branch
from
July 26, 2026 10:35
cfbaffd to
b9f5ef1
Compare
smiggleworth
force-pushed
the
fix/website-askr-font
branch
from
July 26, 2026 10:44
b9f5ef1 to
a7ccab4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Container size="xl"boundary as the header and marketing contentaskr0.0.70, themes 0.0.16, testing 0.0.2) and regenerate versioned API docsVerification
npm run checknpm outdated --jsonreports no outdated direct@askrjs/*packages/docs/using the updated lockfileThe browser connector is unavailable in this session, so interactive visual confirmation is being performed against the live local dev server.
Closes #15