fix: show sidebar on documentation index#14
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Routes the /docs entry point through the docs shell so the documentation index consistently renders with the docs sidebar/navigation/TOC, updates static-output verification expectations accordingly, and eliminates React missing-key warnings in docs lists.
Changes:
- Register
/docsunderDocsLayout(instead of the marketing layout) in both runtime and static route registries. - Update
verify-static-output.tsso/docsis treated as a docs route for layout/marker verification. - Add missing
keyprops to mapped navigation and TOC elements in docs UI.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pages/docs/page.tsx | Adds a key to headings rendering to remove missing-key warnings. |
| src/pages/docs/_layout.tsx | Adds keys to docs sidebar and TOC list rendering to remove missing-key warnings. |
| src/pages/_routes.tsx | Routes /docs through DocsLayout by registering all docsCatalog entries (including /docs) under the docs layout. |
| scripts/verify-static-output.ts | Reclassifies /docs as a docs route in static verification expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13
Summary
/docsthroughDocsLayoutso the documentation entry point includes the sidebar./docsin static verification.Verification
npm run check✅/docsgenerated output contains docs layout, sidebar, navigation, and TOC markers ✅