Skip to content

fix: align Destroyer with published contracts#2

Merged
smiggleworth merged 1 commit into
mainfrom
fix/destroyer-published-route-contract
Jul 25, 2026
Merged

fix: align Destroyer with published contracts#2
smiggleworth merged 1 commit into
mainfrom
fix/destroyer-published-route-contract

Conversation

@smiggleworth

Copy link
Copy Markdown
Contributor

Refresh the Destroyer consumer to the published Askr, server, themes, and UI releases.

  • update the lockfile to @askrjs/askr 0.0.66, server 0.0.10, themes 0.0.16, and ui 0.0.17
  • provide the required trusted rate-limit bucket key
  • keep scoped workflow action pins
  • keep action success in place and validate query invalidation
  • use the semantic link role for Button-asChild browser coverage

Validation: npm run acceptance (unit, production, build, six browser tests).

Fixes #1

Copilot AI review requested due to automatic review settings July 25, 2026 18:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Destroyer to align with the latest published Askr/server/themes/UI contracts, adjusting the server middleware/action response shapes and updating browser coverage to match updated semantics.

Changes:

  • Refreshes the dependency lockfile to newer @askrjs/* releases (askr/server/themes/ui).
  • Updates server behavior to provide an explicit rate-limit bucket key and to return action results without redundant same-path redirects.
  • Adjusts Playwright browser flows to reflect Button-asChild now exposing a semantic link and to rely on query invalidation rather than a manual reload.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/browser/product-flows.spec.ts Updates browser assertions/interactions to use link role for “Inspect logs” and removes an unnecessary reload after saving workspace settings.
src/server/app.ts Adds an explicit rateLimit key function keyed by authenticated session id (or anonymous).
src/server/actions.ts Removes same-path redirects from settings actions, returning only { result } to match updated action contracts/query invalidation behavior.
package-lock.json Pins the repo to the intended published @askrjs/* package versions.
.github/workflows/ci.yml Pins GitHub Actions to specific SHAs for checkout and setup-node across jobs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@smiggleworth
smiggleworth merged commit 2424f04 into main Jul 25, 2026
5 checks passed
@smiggleworth
smiggleworth deleted the fix/destroyer-published-route-contract branch July 25, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit: refresh Destroyer to published canonical package contracts

2 participants