fix: align Destroyer with published contracts#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Destroyer to align with the latest published Askr/server/themes/UI contracts, adjusting the server middleware/action response shapes and updating browser coverage to match updated semantics.
Changes:
- Refreshes the dependency lockfile to newer
@askrjs/*releases (askr/server/themes/ui). - Updates server behavior to provide an explicit rate-limit bucket key and to return action results without redundant same-path redirects.
- Adjusts Playwright browser flows to reflect Button-asChild now exposing a semantic link and to rely on query invalidation rather than a manual reload.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/browser/product-flows.spec.ts |
Updates browser assertions/interactions to use link role for “Inspect logs” and removes an unnecessary reload after saving workspace settings. |
src/server/app.ts |
Adds an explicit rateLimit key function keyed by authenticated session id (or anonymous). |
src/server/actions.ts |
Removes same-path redirects from settings actions, returning only { result } to match updated action contracts/query invalidation behavior. |
package-lock.json |
Pins the repo to the intended published @askrjs/* package versions. |
.github/workflows/ci.yml |
Pins GitHub Actions to specific SHAs for checkout and setup-node across jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh the Destroyer consumer to the published Askr, server, themes, and UI releases.
Validation: npm run acceptance (unit, production, build, six browser tests).
Fixes #1