fix(security): isolate async SSR render context#132
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses the security finding in #131 by removing the module-global async fallback for SSR render context and instead requiring AsyncLocalStorage for async context isolation, failing closed when it isn’t available. This prevents concurrent SSR requests from leaking render context across awaits in environments without proper async context propagation.
Changes:
- Update
withRenderContextAsyncto throw immediately when AsyncLocalStorage-backed isolation is unavailable (no async fallback stack). - Add a concurrent regression test ensuring async fallback contexts are rejected before request work begins.
- Refactor the SSR fallback-context test helper to better control a “no Node versions” runtime simulation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/jsdom/ssr/fallback-context-invariants.test.ts | Adds a concurrency regression asserting async fallback fails closed and does not execute request work. |
| src/ssr/context.ts | Removes the unsafe module-global async fallback stack behavior by throwing when AsyncLocalStorage can’t be used. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131
Uses AsyncLocalStorage for async SSR context isolation and fails closed before request work when the runtime cannot provide it. Synchronous fallback rendering remains supported.
Verification: