fix: bound WebSocket rejection bodies#9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #8 by preventing unbounded buffering of WebSocket upgrade rejection bodies in the Node adapter, enforcing a configurable byte cap and failing closed when the cap is exceeded.
Changes:
- Adds bounded streaming accumulation for WebSocket rejection bodies with cancellation on overflow (default 64 KiB).
- Exposes and validates a
maxRejectionBodyBytesWebSocket option. - Adds a regression test ensuring oversized rejection bodies are cancelled and replaced with a bounded 500 response.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/node.test.ts | Adds a regression test asserting cancellation and bounded 500 response when rejection body exceeds the configured limit. |
| src/websocket.ts | Implements bounded rejection-body reading/cancellation and threads maxRejectionBodyBytes through the rejection path; recomputes emitted content-length. |
| src/contracts.ts | Extends NodeWebSocketOptions with maxRejectionBodyBytes. |
| README.md | Documents the new option and the default 64 KiB rejection-body cap. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8.
Streams rejection bodies into a bounded accumulator, cancels on overflow, defaults the limit to 64 KiB, exposes a validated maxRejectionBodyBytes option, and recomputes the emitted content length.
Regression proof uses a continuing rejection stream with an 8-byte cap and verifies cancellation plus a bounded 500 response. Full local npm run check passes (27 tests, lint, types, build, publint, package checks).