fix: contain static assets across symlinks#5
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a static-asset path traversal issue where lexical path containment checks could be bypassed via in-root symlinks that resolve outside assets.root. It does this by canonicalizing both the configured asset root and the requested asset candidate (post-symlink resolution) before enforcing containment, and adds a regression test.
Changes:
- Canonicalize
assets.rootusingrealpath()and enforce containment against the canonicalized root. - Canonicalize each asset request candidate via
realpath()beforestat()and serving. - Add a non-Windows regression test ensuring symlinks cannot escape the configured asset root.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/serve.ts |
Canonicalizes asset root and resolved candidate paths before enforcing containment and serving static assets. |
tests/node.test.ts |
Adds a regression test for an in-root symlink pointing outside the asset root. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4. Canonicalizes asset roots and candidates before enforcing containment and adds an out-of-root symlink regression.