Skip to content

feat: review custom accessibility primitives - #17

Merged
smiggleworth merged 4 commits into
mainfrom
fix/accessibility-skill-review
Jul 26, 2026
Merged

feat: review custom accessibility primitives#17
smiggleworth merged 4 commits into
mainfrom
fix/accessibility-skill-review

Conversation

@smiggleworth

Copy link
Copy Markdown
Contributor

Summary

  • add opt-in reject-custom-accessibility-primitives skill review prompt
  • detect likely dialog, command-menu shortcut, and focus trap/restoration reimplementations
  • report maintained @askrjs/ui / @askrjs/themes guidance and support inline suppression
  • add positive, negative, and suppression smoke coverage

Validation

  • npm run typecheck
  • npx vitest run tests/cli.smoke.test.ts --pool=forks --maxWorkers=1: 58 passed
  • npm run check: passed
  • npm run test:templates: existing SSG fixture fails because Input lacks min/type props

Closes #16

Copilot AI review requested due to automatic review settings July 26, 2026 15:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an opt-in askr skills review prompt to flag likely reimplementations of accessibility-sensitive UI primitives (dialog, command-menu shortcuts, focus trapping/restoration), with documented inline suppression and smoke coverage to validate behavior.

Changes:

  • Introduces the reject-custom-accessibility-primitives skill review prompt and documents it.
  • Adds smoke tests covering detection and inline suppression for the new prompt.
  • Extends the review runner to support prompt-defined inline suppression.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
tests/cli.smoke.test.ts Adds smoke coverage for listing the new prompt, flagging dialog-like markup, and honoring inline suppression.
src/bin/skill-review.ts Defines the new review prompt and adds support for prompt-level inline suppression in the evaluator.
docs/skill-review-prompts.md Documents the new prompt and its inline suppression directive.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@smiggleworth
smiggleworth merged commit f2c1161 into main Jul 26, 2026
8 checks passed
@smiggleworth
smiggleworth deleted the fix/accessibility-skill-review branch July 26, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add opt-in skill-review checks for likely accessibility primitive reimplementations

2 participants