feat: review custom accessibility primitives - #17
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an opt-in askr skills review prompt to flag likely reimplementations of accessibility-sensitive UI primitives (dialog, command-menu shortcuts, focus trapping/restoration), with documented inline suppression and smoke coverage to validate behavior.
Changes:
- Introduces the
reject-custom-accessibility-primitivesskill review prompt and documents it. - Adds smoke tests covering detection and inline suppression for the new prompt.
- Extends the review runner to support prompt-defined inline suppression.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/cli.smoke.test.ts | Adds smoke coverage for listing the new prompt, flagging dialog-like markup, and honoring inline suppression. |
| src/bin/skill-review.ts | Defines the new review prompt and adds support for prompt-level inline suppression in the evaluator. |
| docs/skill-review-prompts.md | Documents the new prompt and its inline suppression directive. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reject-custom-accessibility-primitivesskill review prompt@askrjs/ui/@askrjs/themesguidance and support inline suppressionValidation
npm run typechecknpx vitest run tests/cli.smoke.test.ts --pool=forks --maxWorkers=1: 58 passednpm run check: passednpm run test:templates: existing SSG fixture fails becauseInputlacksmin/typepropsCloses #16