This repository was archived by the owner on Jul 18, 2024. It is now read-only.
Use sh_binary to wrap run scripts for windows support.#30
Open
christopherschwaab wants to merge 1 commit into
Open
Use sh_binary to wrap run scripts for windows support.#30christopherschwaab wants to merge 1 commit into
christopherschwaab wants to merge 1 commit into
Conversation
Owner
|
I think the tests are failing because shell(s) do not propagate some signals. I don't know if there is a way around it. |
Author
|
Oops, excuse me I'd meant to get back to this but got caught up in other work. I very well may be overlooking something else but it appears that perhaps also the file extension is now wrong in those tests (since on windows it's wrapped in a launcher which has an .exe at the end). I'll have a look at updating the tests when I have a chance hopefully over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows is silly and falls over scripts that aren't wrapped in an exe runner. Wrapping multirun/command with sh_binary should make them usable on windows (at least with msys2 here on 5.1.0) and I think should be benign on saner platforms. Thanks!