Timeout override now works #448#779
Closed
torazar wants to merge 1 commit into
Closed
Conversation
…r timeout if you changed that.
zachdaniel
reviewed
Jun 16, 2026
|
|
||
| use Spark.Dsl.Extension, | ||
| sections: @sections, | ||
| transformers: [AshPostgres.Transformers.AddQueryTimeoutPreparation], |
Contributor
There was a problem hiding this comment.
What's this? I don't think we have this preparation anywhere do we?
Author
There was a problem hiding this comment.
So, that creates a preparation step behind the scene to handle that.
zachdaniel
reviewed
Jun 16, 2026
| @impl true | ||
| def set_context(resource, data_layer_query, context) do | ||
| AshSql.Query.set_context(resource, data_layer_query, AshPostgres.SqlImplementation, context) | ||
| AshPostgres.Sql.Query.set_context(resource, data_layer_query, context) |
Contributor
There was a problem hiding this comment.
I don't see this module anywhere either 🤔
Author
There was a problem hiding this comment.
That points to a module in /lib/sql.
Author
There was a problem hiding this comment.
I see... Guess I forgot to transfer it over. I'll do this merge over, I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
, and it won't simply default to the regular timeout if you changed that.
Contributor checklist
Leave anything that you believe does not apply unchecked.