Skip to content

Fix all warnings thrown by the security audit scanner#525

Open
HasiniSama wants to merge 2 commits into
asgardeo:mainfrom
HasiniSama:audit
Open

Fix all warnings thrown by the security audit scanner#525
HasiniSama wants to merge 2 commits into
asgardeo:mainfrom
HasiniSama:audit

Conversation

@HasiniSama
Copy link
Copy Markdown
Contributor

@HasiniSama HasiniSama commented May 19, 2026

Purpose

$subject

Related: #523

Summary by CodeRabbit

  • Chores

    • Updated development dependencies (Next.js, Vite, undici and others) and workspace overrides for security and compatibility
    • Configured sample packages to use ES modules for improved JavaScript compatibility
  • Refactor

    • Minor TypeScript annotation refinements across UI components — no user-facing behavior changes

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@HasiniSama has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 54 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5fcebc7c-eede-4c75-99bc-db1ab305234f

📥 Commits

Reviewing files that changed from the base of the PR and between f384399 and c3f5a14.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (8)
  • CONTRIBUTING.md
  • packages/nextjs/src/client/components/presentation/OrganizationSwitcher/OrganizationSwitcher.tsx
  • packages/react/src/components/presentation/LanguageSwitcher/BaseLanguageSwitcher.tsx
  • packages/react/src/components/presentation/auth/AuthOptionFactory.tsx
  • packages/react/src/components/presentation/auth/OrganizationUnitPicker/v2/OrganizationUnitPicker.tsx
  • packages/react/src/components/primitives/CopyableText/CopyableText.tsx
  • pnpm-workspace.yaml
  • samples/nuxt/package.json
📝 Walkthrough

Walkthrough

Workspace and package dependency pins are updated (undici, next, axios, various overrides); samples enable ESM and bump vite; several React components receive explicit TypeScript handler parameter and return annotations.

Changes

Dependency and Configuration Updates

Layer / File(s) Summary
Workspace and core package dependency updates
package.json, packages/nextjs/package.json, pnpm-workspace.yaml
Root workspace devDependencies.undici bumped from ^7.21.0 to ^7.24.0; packages/nextjs devDependencies.next bumped from 15.5.12 to 15.5.18; pnpm-workspace.yaml overrides reworked and @asgardeo/auth-spa>axios bumped from 1.13.5 to 1.16.1, plus updated transitive pins (defu, devalue, flatted, lodash, minimatch, picomatch, rollup, tar, undici, vite, etc.).
Sample packages ESM and vite updates
samples/package.json, samples/react-tanstack-router/package.json, samples/teamspace-react/package.json
samples/package.json adds top-level "type": "module"; vite devDependency bumped from 6.4.1 to 6.4.2 in the listed sample packages.

Type annotations for UI handlers

Layer / File(s) Summary
OrganizationSwitcher callbacks
packages/nextjs/src/client/components/presentation/OrganizationSwitcher/OrganizationSwitcher.tsx
CreateOrganization onSuccess and OrganizationList onOrganizationSelect callbacks now include explicit Organization parameter typings and void return annotations.
OrganizationUnitPicker event typings
packages/react/src/components/presentation/auth/OrganizationUnitPicker/v2/OrganizationUnitPicker.tsx
Node container onClick/onKeyDown, toggle button onClick (typed React.MouseEvent), and "Load more" buttons onClick handlers were updated with explicit parameter and void return typings.
Misc UI handler type annotations
packages/react/src/components/presentation/LanguageSwitcher/BaseLanguageSwitcher.tsx, packages/react/src/components/presentation/auth/AuthOptionFactory.tsx, packages/react/src/components/primitives/CopyableText/CopyableText.tsx
Language option onClick, OrganizationUnitPicker onSelect prop in AuthOptionFactory, and CopyableText onClick/catch callbacks now use explicit TypeScript return/parameter annotations; runtime behavior unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • ThaminduDilshan
  • DonOmalVindula
  • brionmario

Poem

🐰 I hopped through pins and bumped some lines,
undici, vite, and axios in new designs.
Handlers now explicit — typed and neat,
samples go ESM and build steps meet.
A tiny rabbit cheers this tidy feat.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; it lacks most required template sections including detailed purpose, checklist items, and security checks. Only the title subject and a related PR link are provided. Complete the description template by filling in all required sections: expand the Purpose section with detailed explanation, mark the Checklist items, confirm Security checks, and address the missing Related Issues/PRs fields.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main objective of the PR: addressing warnings from a security audit scanner. It directly relates to the changeset's purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asgardeo-github-bot
Copy link
Copy Markdown

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants