fix: Onboarding Copy

[JanaeHijaz]

Description

This PR addresses some copy changes for the onboarding flow (for both novice and experienced collectors).

Follow up: A final comb through with design before launch to make sure that we have all final copy.

After:

• Onboarding Auth Page

• Onboarding Questions

• Onboarding Infinite Discovery

• New User Bottom sheet

• Follow Artists screen

• Follow Artists Bottom sheet 1

• Follow Artists Bottom sheet 2

PR Checklist

• I have tested my changes on the following platforms:
  • Android.
  • iOS.
• I hid my changes behind a feature flag, or they don't need one.
• I have included screenshots or videos at least on Android, or I have not changed the UI.
• I have added tests, or my changes don't require any.
• I added an app state migration, or my changes do not require one.
• I have documented any follow-up work that this PR will require, or it does not require any.
• I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

• I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

• copy updates

Need help with something? Have a look at our docs, or get in touch with us.

[artsyit]

This PR contains the following changes:

• Dev changes (copy updates - JanaeHijaz)

Generated by 🚫 dangerJS against 058d3f4

[claude]

Summary

Copy pass over the onboarding flow: curly apostrophes, sentence-case fixes, and reworded headings/CTAs across the auth screens, the experience question, Follow Artists, Infinite Discovery onboarding, and the two completion bottom sheets. Tests were updated alongside each string.

Issues Found

🟡 Important

The experience-question labels are analytics values, not just copy — src/app/Scenes/Onboarding/Screens/Onboarding/Components/QuestionStep.tsx:11-28

{ label: "I’m an experienced collector (4+ works)", experience: "experienced" },
{ label: "I’ve started my collection (1–3 works)", experience: "experienced" },

The label is threaded straight into Segment:

• QuestionStep.tsx:48 — onSelect(option.experience, option.label)
• Introduction.tsx:65 — trackAnsweredExperienceQuestion(label)
• useOnboardingTracking.ts:44 — data_input: buttonText

Swapping ' → ’ and - → – changes the string that lands in data_input. Existing queries filtering on the old labels stop matching, and the funnel splits into two buckets at the release boundary. Either add a stable trackingValue decoupled from the display label, or flag this to whoever owns the onboarding dashboards. Left an inline suggestion.

🟢 Suggestions

"Skip to Home" is now inconsistent with the screens next to it — BrowsePromptStep.tsx:38

The same action stays sentence case at FollowArtists.tsx:73,83,154 and InfiniteDiscoveryHeader.tsx:108,114 ("Skip to home" / "Go to home"). A user hits "Skip to Home" then "Skip to home" on consecutive screens in the beginner path.

Bottom-sheet helper text does not match its buttons — NewUserOnboardingCompletionBottomSheet.tsx:122-136

Go to Home or keep exploring works.
[ See More Works ]
[ Take Me Home ]

The line describes the buttons, so it should use their labels. The order is also flipped relative to the buttons.

Test assertion got weaker — __tests__/InfiniteDiscoveryOnboarding.tests.tsx:54-55

Both regexes resolve to the same <Text> node, so it is one assertion written twice and it no longer pins the punctuation between the sentences. The exact-string form still passes.

Apostrophe typography is still mixed in the auth flow. This PR converts the contractions in the touched files to ’, but nearby user-facing copy on the same screens keeps straight quotes: LoginPasswordStep.tsx:203 ("Don't have an account?"), TermsOfServiceCheckbox.tsx:32 ("I accept Artsy's"), EmailSubscriptionCheckbox.tsx:29 ("Get Artsy's emails…"). Pre-existing, but this PR is the natural place to finish it — the follow-up design comb mentioned in the description would be a good moment.

Areas Reviewed

• Architecture & Design — no structural changes; strings only, plus one removed <Text> in the completion sheet. No new cross-scene imports, no barrel files, no keyboard-API violations.
• Testing — every changed string has a matching test update. QuestionStep itself has no test file, but that predates this PR and Introduction.tests.tsx mocks it.
• Security / Performance — nothing.

Before merge

The screenshots checkbox is unchecked and this is entirely a UI change, including a layout change in NewUserOnboardingCompletionBottomSheet (three text lines collapsed to two, heading bumped to weight="medium"). Please add before/after captures on both iOS and Android — the new heading, "First five saved: We’re beginning to understand your taste.", is longer than the line it replaced and now renders at lg-display medium, so wrapping is worth eyeballing on a small Android screen.