fix: tests after AREnableRedirectForVideoFeatureType ff addition - #12932
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
leamotta
approved these changes
Nov 4, 2025
MrSltun
approved these changes
Nov 4, 2025
Contributor
Contributor
|
thank you and sorry! did we ever figure out why the tests seem to pass from the echo deploys still? I can poke if not |
Member
Author
|
feel free to poke at it, I have created a ticket in the sapphire board to make sure we address this, I think what happens is that the tests run before staging echo gets deployed with the old state and this is why it fails after deployment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
After the deployment of echo the Features.tests.tsx started failing, this PR addresses this issue for now but we need to add another test covering the case for when the feature flag is enabled.
Also created a ticket to fix the behavior of echo and
run-eigen-teststo respect the new featureflagsPR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.