Skip to content

fix: eigen-echo test integration #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkartalis merged 1 commit into from
Nov 6, 2025
Merged

fix: eigen-echo test integration #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ workflows:
only:
- main
- production
- fix-ci

@gkartalis gkartalis Nov 6, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was never used

context: echo
- run-eigen-tests:
requires:
Expand All @@ -46,5 +45,4 @@ workflows:
only:
- main
- production
- fix-ci

@gkartalis gkartalis Nov 6, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

context: echo
1 change: 1 addition & 0 deletions Echo.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@
{ name: 'AREnableQuickLinksAnimation2', value: true },
{ name: 'AREnableRedesignedSettings', value: true },
{ name: 'ARShowOnboardingPriceRangeScreen', value: true },
{ name: 'AREnableFailingTestEcho', value: false },

// deprecated flags. REMOVE OR CHANGE WITH CARE.
{ name: 'AREnableInfiniteDiscovery', value: true }, // 2025-04-24 removed artsy/eigen#11769
Expand Down